Skip to content

chore: remove stale ts-node config remnants#13698

Open
chenjiahan wants to merge 1 commit intomainfrom
chenjiahan/chore-remove-ts-node-remnants
Open

chore: remove stale ts-node config remnants#13698
chenjiahan wants to merge 1 commit intomainfrom
chenjiahan/chore-remove-ts-node-remnants

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Apr 14, 2026

Summary

  • remove the obsolete ts-node-register CLI config fixture and its builtin loader semantics test now that TypeScript configs are loaded via jiti
  • drop leftover ts-node sections from repository tsconfig files that are no longer used after the loader migration

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings April 14, 2026 05:50
@chenjiahan chenjiahan requested a review from hardfist as a code owner April 14, 2026 05:50
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes leftover ts-node-based config fixtures and ts-node-specific tsconfig settings, aligning the repo with the current TypeScript config loading approach (via jiti) and reducing stale maintenance surface.

Changes:

  • Removed the ts-node-register CLI config fixture and its associated “builtin loader semantics” test.
  • Dropped obsolete "ts-node" sections from various tsconfig.json files used in tests/benchmarks and packages/rspack.
  • Kept existing jiti loader coverage in config.test.ts as the remaining validation path.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/e2e/tsconfig.json Removes unused ts-node config block from e2e tsconfig.
tests/bench/fixtures/ts-react/tsconfig.json Removes unused ts-node compilerOptions override from benchmark fixture.
packages/rspack/tsconfig.browser.json Removes unused ts-node config from browser tsconfig.
packages/rspack-cli/tests/build/config/ts-node-register/tsconfig.json Deletes obsolete fixture tsconfig.
packages/rspack-cli/tests/build/config/ts-node-register/rspack.config.ts Deletes obsolete fixture rspack config.
packages/rspack-cli/tests/build/config/ts-node-register/main.ts Deletes obsolete fixture entry file.
packages/rspack-cli/tests/build/config/config.test.ts Removes the test suite that depended on the deleted fixture and old loader semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB 0
react-10k 5.7 MB 0
react-5k 2.7 MB 0
rome 984.1 KB 0
react-1k 826.2 KB 0
ui-components 5.0 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 5115797 to feat(cli): use jiti to load typescript config (#13690) by hardfist

🎉 Size decreased by 5.34KB from 49.39MB to 49.38MB (⬇️0.01%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 14, 2026

Merging this PR will improve performance by 4.63%

⚡ 2 improved benchmarks
✅ 26 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation rust@concatenate_module_code_generation 142.1 ms 135.8 ms +4.63%
Simulation rust@create_chunk_ids 10.6 ms 10.3 ms +2.89%

Comparing chenjiahan/chore-remove-ts-node-remnants (5115797) with main (af4e32e)

Open in CodSpeed

@chenjiahan chenjiahan enabled auto-merge (squash) April 14, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants