Conversation
JDOM10
force-pushed
the
feat/upgrade-nodejs
branch
from
944b9e7 to
256509f
Compare
SbsCruz
approved these changes
Apr 17, 2026
Comment on lines
+48
to
+49
| // eslint-disable-next-line @stylistic/max-len | ||
| export function getExpectedAndReceivedStyles(actual: Element, expected: Partial<CSSStyleDeclaration>): StyleDeclaration[] { |
Contributor
There was a problem hiding this comment.
what about splitting it into 2 lines so we don't disable eslint rules, wdyt?
Collaborator
There was a problem hiding this comment.
Thanks for noticing this Sebas, I just split it into several lines!
suany0805
commented
Apr 17, 2026
Contributor
Author
suany0805
left a comment
suany0805
left a comment
There was a problem hiding this comment.
This is the integration branch for node js upgrade work, this was mostly worked by Jose. Looks good to be merged :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant updates to the project's linting configuration, Node.js version support, and development dependencies. The main changes include migrating from the legacy ESLint configuration to the new flat config system, updating Node.js version requirements across the project, and refreshing TypeScript and related dependencies for all example packages.
Linting and Configuration Updates:
.eslintrc.jsonand.eslintignorefiles to a neweslint.config.mjsusing the ESLint flat config system, with updated plugin usage and modernized rule sets. This change streamlines and modernizes the linting setup. [1] [2] [3]Node.js Version Upgrades:
.nvmrc,package.json, and CI workflow to support Node.js versions 20 and above, including the latest LTS and current releases. This ensures compatibility with the latest Node.js features and security updates. [1] [2] [3]Example Package Maintenance:
@types/nodedependencies in all example packages (jest,mocha,symbolPlugin) to the latest versions for improved type safety and compatibility. [1] [2] [3]checkscript to example packages to streamline compilation and testing workflows. [1] [2] [3]Code Quality Improvements: