fix(CI): Use github format for standardrb output#6446
Merged
tvdeyen merged 3 commits intosolidusio:mainfrom Apr 22, 2026
Merged
fix(CI): Use github format for standardrb output#6446tvdeyen merged 3 commits intosolidusio:mainfrom
tvdeyen merged 3 commits intosolidusio:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6446 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 990 990
Lines 20793 20793
=======================================
Hits 18645 18645
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
82051d8 to
f6f8d4d
Compare
Currently we just see a Ruby stacktrace and not any usefull hint on what linting error happened in a PR. This adds GitHub comments and stops redirecting all output to stdout, but use the --out instead for the results.xml.
f6f8d4d to
2829e36
Compare
These were using deprecated Node 20 action syntax, which produces a lot of annoying warnings in the CI
The GH action linter flagged this and it is actually very useful
2829e36 to
6b04b57
Compare
adammathys
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we just see a Ruby stacktrace and not any useful hint on what linting error happened in a PR.
This adds GitHub comments and only redirects the XML to the file while still printing the error and hiding the Rake stack trace. Much cleaner and more human friendly.