Skip to content

fix(CI): Use github format for standardrb output#6446

Merged
tvdeyen merged 3 commits intosolidusio:mainfrom
blish:fix-lint-ci-output
Apr 22, 2026
Merged

fix(CI): Use github format for standardrb output#6446
tvdeyen merged 3 commits intosolidusio:mainfrom
blish:fix-lint-ci-output

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Apr 22, 2026

Currently we just see a Ruby stacktrace and not any useful hint on what linting error happened in a PR.

This adds GitHub comments and only redirects the XML to the file while still printing the error and hiding the Rake stack trace. Much cleaner and more human friendly.

CleanShot 2026-04-22 at 18 49 02@2x CleanShot 2026-04-22 at 18 41 06@2x CleanShot 2026-04-22 at 18 39 02@2x

@tvdeyen tvdeyen requested a review from a team as a code owner April 22, 2026 15:59
@github-actions github-actions Bot added changelog:repository Changes to the repository not within any gem changelog:solidus_core Changes to the solidus_core gem and removed changelog:repository Changes to the repository not within any gem labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (bbd0e75) to head (6b04b57).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6446   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         990      990           
  Lines       20793    20793           
=======================================
  Hits        18645    18645           
  Misses       2148     2148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the fix-lint-ci-output branch 3 times, most recently from 82051d8 to f6f8d4d Compare April 22, 2026 16:35
Currently we just see a Ruby stacktrace and not any
usefull hint on what linting error happened in a PR.

This adds GitHub comments and stops redirecting all
output to stdout, but use the --out instead for the
results.xml.
@tvdeyen tvdeyen force-pushed the fix-lint-ci-output branch from f6f8d4d to 2829e36 Compare April 22, 2026 16:39
tvdeyen added 2 commits April 22, 2026 18:58
These were using deprecated Node 20 action syntax,
which produces a lot of annoying warnings in the CI
The GH action linter flagged this and it is actually very useful
@tvdeyen tvdeyen force-pushed the fix-lint-ci-output branch from 2829e36 to 6b04b57 Compare April 22, 2026 16:58
@github-actions github-actions Bot added changelog:repository Changes to the repository not within any gem and removed changelog:solidus_core Changes to the solidus_core gem labels Apr 22, 2026
@tvdeyen tvdeyen enabled auto-merge April 22, 2026 17:12
@tvdeyen tvdeyen merged commit 65572c8 into solidusio:main Apr 22, 2026
39 checks passed
@tvdeyen tvdeyen deleted the fix-lint-ci-output branch April 22, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants