Skip to content

fix: clean up orphan drafts when tag creation is blocked#750

Merged
chenrui333 merged 1 commit intosoftprops:masterfrom
chenrui333:fix-722-orphan-draft
Mar 15, 2026
Merged

fix: clean up orphan drafts when tag creation is blocked#750
chenrui333 merged 1 commit intosoftprops:masterfrom
chenrui333:fix-722-orphan-draft

Conversation

@chenrui333
Copy link
Copy Markdown
Collaborator

@chenrui333 chenrui333 commented Mar 15, 2026 •
edited
Loading

Summary

  • delete the draft release created by this run when finalization fails because tag creation is blocked by repository rules
  • avoid deleting pre-existing draft releases by tracking whether the release was actually created by this invocation
  • cover the blocked-tag cleanup path in unit tests

Fixes #722

@chenrui333
fix: clean up orphan drafts when tag creation is blocked
b7e4707 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the bug Something isn't working label Mar 15, 2026
@chenrui333 chenrui333 merged commit 488ac71 into softprops:master Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creation of release with non-existent TAG leaves draft release when TAG creation is not allowed

1 participant

@chenrui333