fix: handle upload already_exists races across workflows#745
Merged
chenrui333 merged 2 commits intosoftprops:masterfrom Mar 15, 2026
Merged
fix: handle upload already_exists races across workflows#745chenrui333 merged 2 commits intosoftprops:masterfrom
chenrui333 merged 2 commits intosoftprops:masterfrom
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Collaborator
|
Thanks @api2062! |
3 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition when multiple workflows upload an asset with the same filename to the same release tag.
When
overwrite_filesis enabled (default), concurrent runs can still hit:Validation Failed: {"resource":"ReleaseAsset","code":"already_exists","field":"name"}because another workflow may upload between the initial asset check and upload call.
What changed
upload():422+already_exists, the action now:retries upload after deleting conflicting asset on 422 already_exists race.Fixes #740
Validation
npx vitest run __tests__/github.test.tsnpm run typechecknpm run build