feat: add ability to filter jobs by tags#548
Open
golanglemonade wants to merge 1 commit intoriverqueue:masterfrom
Open
feat: add ability to filter jobs by tags#548golanglemonade wants to merge 1 commit intoriverqueue:masterfrom
golanglemonade wants to merge 1 commit intoriverqueue:masterfrom
Conversation
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Collaborator
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
brandur
reviewed
Apr 21, 2026
Collaborator
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Thanks @golanglemonade! Thoughts on autocomplete for tag names? A bit harder maybe than queue names or job kinds, but seems like it'd be make the feature a lot more useful.
|
|
||
| default: | ||
| return nil, apierror.NewBadRequestf("Invalid facet %q. Valid facets are: job_kind, queue_name", req.Facet) | ||
| default: |
Collaborator
There was a problem hiding this comment.
Think this whitespace is wrong and should go back to how it was before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a lot of jobs with the same kind, but different tags. This will make it much easier to filter the data and find jobs.