Open
Conversation
Member
Author
|
I have an upstream fix here, which should obviate most of this bevyengine/bevy#23844 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, this logic is tricky due to the double buffering that happens. When MSAA is enabled, we were potentially writing into a buffer that doesn't get resolved at the start of the next frame, because Bevy always resets it's internal ping-pong counter at the start of every frame.
So, for example, if we write into the B texture, at the start of the next frame the ping-pong gets reset to A and we resolve the A texture, overwriting our manual writes. If, by happenchance, we correctly had written into A instead of B, everything would appear to work.
This is a bit inefficient, but we unconditionally copy from main to other every time we write to ensure that our writes are visible on both textures regardless of which one is currently active. We could request upstream changes here if this matters.