Expose zend_reflection_property_set_raw_value, zend_reflection_property_set_raw_value_without_lazy_initialization

[arnaud-lb]

This exposes the functionality of ReflectionProperty::setRawValue() and ReflectionProperty::setRawValueWithoutLazyInitialiation() to C extensions.

Test failure unrelated.

[DanielEScherzer]

Not sure the current interface is the best to expose, e.g. the void *cache_slot[3] parameters are not really documented

What is the issue with having other extensions just call the reflection methods via the normal mechanism for calling class methods?

[nicolas-grekas]

What is the issue with having other extensions just call the reflection methods via the normal mechanism for calling class methods

CPU overhead!

[arnaud-lb]

@DanielEScherzer I've documented the cache_slot parameter in the comment above the declaration of zend_reflection_property_set_raw_value. It is not uncommon to find such cache_slot parameter in the code base, on functions related to property accesses.

If you prefer, I can change the API to something like this:

typedef reflection_object zend_reflection_property;

PHPAPI zend_reflection_property *zend_reflection_property_create(zend_class_entry *ce, zend_string *name);
PHPAPI void zend_reflection_property_set_raw_value(zend_reflection_property *refl_prop, zend_object *object, zval *value);

What is the issue with having other extensions just call the reflection methods via the normal mechanism for calling class methods?

In addition to being faster, this also provides a nicer API. Instantiating objects and calling methods is not straightforward in C.

[Girgias]

The other thing to mention is calling a "PHP" function/method from C AFAIK requires setting up new VM stacks compared to "just" running in a loop. The other thing is that for global functions those can be disabled by an INI setting. (For classes and class methods that's no longer an issue since 8.5 as the disable_class INI setting got removed)