Skip to content

Zend: Fix swapped arguments in MSVC InterlockedCompareExchange CAS #21759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdmondDantes wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Zend: Fix swapped arguments in MSVC InterlockedCompareExchange CAS #21759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Zend/zend_atomic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ static zend_always_inline int zend_atomic_int_exchange_ex(zend_atomic_int *obj,
}

static zend_always_inline bool zend_atomic_bool_compare_exchange_ex(zend_atomic_bool *obj, bool *expected, bool desired) {
bool prev = (bool) InterlockedCompareExchange8(&obj->value, *expected, desired);
bool prev = (bool) InterlockedCompareExchange8(&obj->value, desired, *expected);
if (prev == *expected) {
return true;
} else {
Expand All @@ -114,7 +114,7 @@ static zend_always_inline bool zend_atomic_bool_compare_exchange_ex(zend_atomic_
}

static zend_always_inline bool zend_atomic_int_compare_exchange_ex(zend_atomic_int *obj, int *expected, int desired) {
int prev = (int) InterlockedCompareExchange(&obj->value, *expected, desired);
int prev = (int) InterlockedCompareExchange(&obj->value, desired, *expected);
if (prev == *expected) {
return true;
} else {
Expand Down
Loading