fix: using variable interpolation `${{ in nodejs-org.yml...#3819
Open
orbisai0security wants to merge 1 commit intonvm-sh:masterfrom
Open
fix: using variable interpolation `${{ in nodejs-org.yml...#3819orbisai0security wants to merge 1 commit intonvm-sh:masterfrom
orbisai0security wants to merge 1 commit intonvm-sh:masterfrom
Conversation
…tion security vulnerability Automated security fix generated by Orbis Security AI
Member
|
This is using entirely trusted input, but if it were a security issue, you just irresponsibly disclosed it. |
Author
|
Thanks for flagging that. I didn’t mean to imply there was a known exploitable vulnerability here. My review was focused on defence-in-depth: avoiding ${{ ... }} expansion directly inside run: and preferring passing values via env, which is a common hardening pattern. I didn’t share any new exploit steps, affected versions, or a demonstrated impact, just a recommendation aligned with the rule this PR is already addressing. If you’d prefer, I’m happy to rephrase my comment to make it clear this is hardening rather than a confirmed security issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
.github/workflows/nodejs-org.yml.Vulnerability
yaml.github-actions.security.run-shell-injection.run-shell-injection.github/workflows/nodejs-org.yml:34Description: Using variable interpolation
${{...}}withgithubcontext data in arun:step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code.githubcontext data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable withenv:to store the data and use the environment variable in therun:script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".Changes
.github/workflows/nodejs-org.ymlVerification
Automated security fix by OrbisAI Security