Skip to content

fix: using variable interpolation `${{ in nodejs-org.yml...#3819

Open
orbisai0security wants to merge 1 commit intonvm-sh:masterfrom
orbisai0security:fix-fix-github-actions-shell-injection-nodejs-org
Open

fix: using variable interpolation `${{ in nodejs-org.yml...#3819
orbisai0security wants to merge 1 commit intonvm-sh:masterfrom
orbisai0security:fix-fix-github-actions-shell-injection-nodejs-org

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix high severity security issue in .github/workflows/nodejs-org.yml.

Vulnerability

Field Value
ID yaml.github-actions.security.run-shell-injection.run-shell-injection
Severity HIGH
Scanner semgrep
Rule yaml.github-actions.security.run-shell-injection.run-shell-injection
File .github/workflows/nodejs-org.yml:34

Description: Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".

Changes

  • .github/workflows/nodejs-org.yml

Verification

  • Build not verified
  • Scanner re-scan not performed
  • LLM code review not performed

Automated security fix by OrbisAI Security

…tion security vulnerability

Automated security fix generated by Orbis Security AI
@ljharb
Copy link
Copy Markdown
Member

ljharb commented Apr 8, 2026

This is using entirely trusted input, but if it were a security issue, you just irresponsibly disclosed it.

@orbisai0security
Copy link
Copy Markdown
Author

Thanks for flagging that. I didn’t mean to imply there was a known exploitable vulnerability here. My review was focused on defence-in-depth: avoiding ${{ ... }} expansion directly inside run: and preferring passing values via env, which is a common hardening pattern.

I didn’t share any new exploit steps, affected versions, or a demonstrated impact, just a recommendation aligned with the rule this PR is already addressing. If you’d prefer, I’m happy to rephrase my comment to make it clear this is hardening rather than a confirmed security issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants