Skip to content

chore: prefer EoL capitalization of EOL#8824

Closed
MattIPv4 wants to merge 3 commits intomainfrom
MattIPv4/eol-capitalization
Closed

chore: prefer EoL capitalization of EOL#8824
MattIPv4 wants to merge 3 commits intomainfrom
MattIPv4/eol-capitalization

Conversation

@MattIPv4
Copy link
Copy Markdown
Member

@MattIPv4 MattIPv4 commented Apr 16, 2026

Description

Weird, I feel we should use EoL as it is the proper capitalization of End-of-Life.

#8817 (comment)

I've currently included updating all the translations here, as it is just a search/replace operation, but I can drop that commit if that should be left to Crowdin instead.

Validation

All references to EOL, outside of historical blog posts, updated to use EoL.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Apr 16, 2026 10:07pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website @nodejs/marketing @nodejs/releasers

Please review the changes when you have a chance. Thank you! 🙏

@MattIPv4 MattIPv4 changed the title chore: chore: prefer EoL capitalization of EOL Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.85%. Comparing base (5a6d7d2) to head (7ba66ad).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8824      +/-   ##
==========================================
- Coverage   73.90%   73.85%   -0.05%     
==========================================
  Files         105      105              
  Lines        8889     8889              
  Branches      326      327       +1     
==========================================
- Hits         6569     6565       -4     
- Misses       2319     2323       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattIPv4 MattIPv4 marked this pull request as ready for review April 16, 2026 21:55
@MattIPv4 MattIPv4 requested review from a team as code owners April 16, 2026 21:55
Copilot AI review requested due to automatic review settings April 16, 2026 21:55
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 16, 2026

PR Summary

Low Risk
Primarily a naming/copy consistency change; the main risk is missing a EOL reference leading to mismatched status comparisons or incorrect UI filtering.

Overview
Standardizes the Node.js release status constant from EOL to EoL end-to-end, updating NodeReleaseStatus, the release data generator (getNodeReleaseStatus), UI mappings (STATUS_KIND_MAP / status ordering), and UI conditionals (EoL tables + alert box).

Updates tests and a broad set of site content/i18n strings and docs to use the preferred EoL capitalization in user-facing copy.

Reviewed by Cursor Bugbot for commit 7ba66ad. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.53 MB
New Total Size 3.53 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (6)
Name Size
.next/static/chunks/aca34ad4abdecec8.js 41.61 KB
.next/static/chunks/aad9bd8fdabef698.js 197.80 KB
.next/static/chunks/1b8858078bfb5938.js 135.99 KB
.next/static/chunks/c9c279dfe6efd9d6.js 27.46 KB
.next/static/chunks/a0d4dd9163b7d74c.js 562.87 KB
.next/static/chunks/e125b379cb4a24c5.js 562.87 KB
➖ Removed Assets (6)
Name Size
.next/static/chunks/63450f720af1e9b2.js 41.61 KB
.next/static/chunks/99cbc82a0c4dccf5.js 197.80 KB
.next/static/chunks/faccbf520c4f877e.js 135.99 KB
.next/static/chunks/9f2217484c2728b3.js 27.46 KB
.next/static/chunks/66f9cbadad6129f6.js 562.87 KB
.next/static/chunks/8546ab23612cb72d.js 562.87 KB

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes “End-of-Life” acronym capitalization from EOL to EoL across the site’s UI copy and (notably) the release-status values used in runtime data/types.

Changes:

  • Updates user-facing strings in UI components, docs, and pages to use EoL instead of EOL.
  • Changes the release status value/type from 'EOL' to 'EoL' and updates related mappings, comparisons, and tests.
  • Applies the same replacement across multiple translated locale JSON files and non-English MD/MDX pages.

Reviewed changes

Copilot reviewed 55 out of 55 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/ui-components/src/Common/BaseButton/index.stories.tsx Updates Storybook label to EoL.
packages/i18n/src/locales/zh-tw.json Updates translated warning string to EoL.
packages/i18n/src/locales/zh-cn.json Updates translated warning string to EoL.
packages/i18n/src/locales/uk.json Updates multiple translated strings to EoL.
packages/i18n/src/locales/ta.json Updates multiple translated strings to EoL.
packages/i18n/src/locales/ro.json Updates multiple translated strings to EoL.
packages/i18n/src/locales/pt-br.json Updates multiple translated strings to EoL.
packages/i18n/src/locales/ko.json Updates translated warning string to EoL.
packages/i18n/src/locales/id.json Updates multiple translated strings to EoL.
packages/i18n/src/locales/fr.json Updates translated navigation label to EoL.
packages/i18n/src/locales/en.json Updates English strings to EoL.
docs/site-config.md Updates docs wording to EoL.
docs/partners.md Updates docs wording to EoL.
apps/site/util/download/constants.json Updates status ordering value to EoL.
apps/site/types/releases.ts Changes NodeReleaseStatus union member from EOL to EoL.
apps/site/pages/zh-cn/index.mdx Updates localized page copy to EoL.
apps/site/pages/zh-cn/about/previous-releases.mdx Updates localized page copy to EoL.
apps/site/pages/uk/index.mdx Updates localized page copy to EoL.
apps/site/pages/uk/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/uk/about/previous-releases.mdx Updates localized page copy to EoL.
apps/site/pages/uk/about/partners.mdx Updates localized page copy to EoL.
apps/site/pages/uk/about/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/ta/index.mdx Updates localized page copy to EoL.
apps/site/pages/ta/about/previous-releases.mdx Updates localized page copy to EoL.
apps/site/pages/ta/about/partners.mdx Updates localized page copy to EoL.
apps/site/pages/ta/about/eol.mdx Updates localized page header/body to EoL.
apps/site/pages/ro/index.mdx Updates localized page copy to EoL.
apps/site/pages/ro/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/ro/about/previous-releases.mdx Updates localized page copy to EoL.
apps/site/pages/pt-br/index.mdx Updates localized page copy to EoL.
apps/site/pages/pt-br/about/previous-releases.mdx Updates localized page copy to EoL.
apps/site/pages/pt-br/about/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/ja/eol.mdx Updates localized page frontmatter/body to EoL (partial).
apps/site/pages/ja/about/partners.mdx Updates localized page copy to EoL (partial).
apps/site/pages/ja/about/eol.mdx Updates localized page frontmatter/body to EoL (partial).
apps/site/pages/id/index.mdx Updates localized page copy to EoL.
apps/site/pages/id/about/previous-releases.mdx Updates localized page copy to EoL.
apps/site/pages/id/about/partners.mdx Updates localized page copy to EoL.
apps/site/pages/id/about/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/fr/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/fr/about/partners.mdx Updates localized page copy to EoL.
apps/site/pages/fr/about/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/es/about/previous-releases.mdx Updates localized page copy to EoL.
apps/site/pages/es/about/eol.mdx Updates localized page frontmatter/body to EoL.
apps/site/pages/en/index.mdx Updates English homepage copy to EoL.
apps/site/pages/en/blog/announcements/evolving-the-nodejs-release-schedule.md Updates blog content table/link text to EoL.
apps/site/pages/en/about/previous-releases.mdx Updates English about-page copy to EoL.
apps/site/pages/en/about/partners.mdx Updates English partners page copy to EoL.
apps/site/pages/en/about/eol.mdx Updates English EoL page copy to EoL and related section headers.
apps/site/next.constants.mjs Updates STATUS_KIND_MAP key to EoL.
apps/site/next-data/generators/releaseData.mjs Changes generated status value to EoL.
apps/site/next-data/generators/tests/releaseData.test.mjs Updates test expectations/text for EoL.
apps/site/components/withReleaseAlertBox.tsx Updates switch case to handle EoL.
apps/site/components/EOL/EOLReleaseTable/index.tsx Updates filter to match EoL status.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/i18n/src/locales/zh-cn.json
Comment thread apps/site/pages/uk/eol.mdx
Comment thread apps/site/pages/ja/eol.mdx Outdated
Comment thread apps/site/pages/ja/about/eol.mdx Outdated
Comment thread apps/site/pages/ja/about/partners.mdx Outdated
Comment thread packages/ui-components/src/Common/BaseButton/index.stories.tsx Outdated
Copy link
Copy Markdown
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 17, 2026

OOC, why is it EOL and not EoL? Shouldn't EoL be the right capitalization? Anyways, fine to leave as-is.

@MattIPv4 MattIPv4 closed this Apr 17, 2026
@MattIPv4 MattIPv4 deleted the MattIPv4/eol-capitalization branch April 17, 2026 10:15
@bmuenzenmeyer
Copy link
Copy Markdown
Contributor

bmuenzenmeyer commented Apr 17, 2026

OOC, why is it EOL and not EoL?

I think it's fair criticism, and I tried finding authoritative grammar guides to this effect, and gave up with myself and a couple sources concluding "English doesn't always make sense..."

  • most initialisms as pronounced letter by letter. We do that too here, EOL... E-O-L
  • Acronyms on the other hand are pronounced as a word. NASA, not N-A-S-A. Which we choose for each circumstance seems to be "common knowledge"... unwritten rules.
  • many acronyms and initialisms are proper nouns themselves, and are all capped to separate themselves from prose
  • to confuse matters more, many initialisms or acronyms do drop minor words. FBI, OPEC... so if anything, it should be EL, not EOL or EoL (lets not do this)
  • initialisms we use fully and don't think twice about (LGTM, ASAP, PTAL)

@bmuenzenmeyer
Copy link
Copy Markdown
Contributor

oh, and OOC 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants