feat(react-doctor): add CLI loading for external oxlint plugins and rules#125
Draft
feat(react-doctor): add CLI loading for external oxlint plugins and rules#125
Conversation
Co-authored-by: Aiden Bai <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--plugin <specifier...>--rule <plugin/rule=off|warn|error>scaninto oxlint config generationreact-doctor.config.json(plugins,rules)Implementation details
ScanOptionsandReactDoctorConfigwith:plugins?: string[]ruleLevels?: Record<string, string>(scan-time)rules?: Record<string, string>(config)createOxlintConfig()to merge:externalJsPlugins)ruleLevels)runOxlint()to:diagnose()to honor config plugins/rulesValidation
pnpm testpnpm lintpnpm --filter react-doctor run typecheckpnpm formatTests
tests/run-oxlint.test.tsfor external plugin loading from a relative file pathtests/fixtures/basic-react/external-plugin.mjsand verified diagnostics are produced when rule is enabled