Skip to content

feat(react-doctor): add CLI loading for external oxlint plugins and rules#125

Draft
aidenybai wants to merge 1 commit intomainfrom
cursor/cli-plugin-loading-18c1
Draft

feat(react-doctor): add CLI loading for external oxlint plugins and rules#125
aidenybai wants to merge 1 commit intomainfrom
cursor/cli-plugin-loading-18c1

Conversation

@aidenybai
Copy link
Copy Markdown
Member

Summary

  • add CLI support for external plugin loading with --plugin <specifier...>
  • add CLI rule-level overrides with --rule <plugin/rule=off|warn|error>
  • thread plugin/rule settings through scan into oxlint config generation
  • support config-based plugin/rule defaults in react-doctor.config.json (plugins, rules)
  • resolve plugin specifiers from the scanned project root (path or package)

Implementation details

  • extended ScanOptions and ReactDoctorConfig with:
    • plugins?: string[]
    • ruleLevels?: Record<string, string> (scan-time)
    • rules?: Record<string, string> (config)
  • updated createOxlintConfig() to merge:
    • additional JS plugins (externalJsPlugins)
    • rule overrides (ruleLevels)
  • updated runOxlint() to:
    • resolve external plugin specifiers using project-root module resolution
    • pass resolved plugin specifiers and rule levels into generated oxlint config
  • updated public API diagnose() to honor config plugins/rules

Validation

  • pnpm test
  • pnpm lint
  • pnpm --filter react-doctor run typecheck
  • pnpm format

Tests

  • added integration coverage in tests/run-oxlint.test.ts for external plugin loading from a relative file path
  • added fixture plugin tests/fixtures/basic-react/external-plugin.mjs and verified diagnostics are produced when rule is enabled
Open in Web Open in Cursor 

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-doctor-website Ready Ready Preview, Comment Apr 14, 2026 1:24am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants