Skip to content

<random>: Remove escape hatch for const distribution operators#6246

Open
StephanTLavavej wants to merge 1 commit intomicrosoft:mainfrom
StephanTLavavej:remove-distribution-const-escape-hatch
Open

<random>: Remove escape hatch for const distribution operators#6246
StephanTLavavej wants to merge 1 commit intomicrosoft:mainfrom
StephanTLavavej:remove-distribution-const-escape-hatch

Conversation

@StephanTLavavej
Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej commented Apr 10, 2026

This escape hatch was added by #2732 on 2022-05-23 shipping in VS 2022 17.3. We've never needed to give it to any customers, and it hasn't been necessary in our Real World Code test suite. It's time to remove this escape hatch and make the fix unconditional.

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 10, 2026 21:25
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Apr 10, 2026
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Apr 10, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Apr 10, 2026
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 about this existing in the first place

@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in STL Code Reviews Apr 13, 2026
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 15, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member Author

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Status: Merging

Development

Successfully merging this pull request may close these issues.

2 participants