Skip to content

Document DateTime dialog field timezone and manual entry#8892

Open
Combs7th wants to merge 3 commits intomasterfrom
claude/issue-8890-20260415-0051
Open

Document DateTime dialog field timezone and manual entry#8892
Combs7th wants to merge 3 commits intomasterfrom
claude/issue-8890-20260415-0051

Conversation

@Combs7th
Copy link
Copy Markdown
Contributor

Adds a capability note to the Interactive Dialogs description in the incoming webhooks integrations guide, documenting the new DateTime field features available from Mattermost server v11.6.0: configurable IANA timezone display (with timezone label shown in the picker) and optional manual time entry for exact typed times.

Closes #8890

Generated with Claude Code

…l entry (v11.6.0)

Add capability note to the Interactive Dialogs description in the
incoming webhooks integrations guide, documenting the new DateTime
field features available from Mattermost server v11.6.0: configurable
IANA timezone display (with timezone label shown in the picker) and
optional manual time entry for exact typed times.

Co-authored-by: Combs7th <[email protected]>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fdd00f65-729b-440c-9bf1-0ce8aec90174

📥 Commits

Reviewing files that changed from the base of the PR and between 3a8f121 and ccdd975.

📒 Files selected for processing (1)
  • source/integrations-guide/incoming-webhooks.rst
✅ Files skipped from review due to trivial changes (1)
  • source/integrations-guide/incoming-webhooks.rst

📝 Walkthrough

Walkthrough

Documentation update to Interactive Dialogs in incoming-webhooks.rst: documents new DateTime field capabilities in Mattermost server v11.6.0 (IANA timezone display configuration and manual time entry), plus minor formatting fixes (straight quotes) and EOF newline normalization.

Changes

Cohort / File(s) Summary
Documentation Updates
source/integrations-guide/incoming-webhooks.rst
Add notes about DateTime interactive-dialog field options: configurable IANA timezone display and optional manual time entry; fix straight quotes in the Interactive Dialogs bullet and ensure file ends with a newline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: documenting new DateTime dialog field features (timezone and manual entry).
Description check ✅ Passed The description is directly related to the changeset, explaining the documentation updates for DateTime field timezone and manual entry capabilities in v11.6.0.
Linked Issues check ✅ Passed The PR updates the Interactive Dialogs section documenting DateTime field timezone-aware display (IANA timezone with picker label) and manual time entry capabilities from v11.6.0, directly addressing #8890 requirements.
Out of Scope Changes check ✅ Passed All changes are scoped to documenting the specific DateTime field capabilities in the incoming webhooks integrations guide; no extraneous modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-8890-20260415-0051

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Combs7th Combs7th added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor Guidance labels Apr 15, 2026
@Combs7th Combs7th added this to the v11.6.0 milestone Apr 15, 2026
@Combs7th Combs7th requested a review from sbishel April 15, 2026 01:07
@Combs7th
Copy link
Copy Markdown
Contributor Author

@sbishel - Do the above doc updates look accurate to you?

@github-actions
Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA c74b63b

Copy link
Copy Markdown
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@github-actions
Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 3a8f121

@Combs7th Combs7th requested a review from esethna April 16, 2026 00:19
@Combs7th
Copy link
Copy Markdown
Contributor Author

@esethna - Ready for merge.

Copy link
Copy Markdown
Contributor

@esethna esethna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Combs7th can we review this with the "Novice Nate" persona? I think Nate would be confused about what this means.

Similarly, "Editor Evie" might not like the sentence structure.

Personas: https://github.com/mattermost/docs/tree/master/.cursor/rules

@Combs7th
Copy link
Copy Markdown
Contributor Author

@claude - Please give this review another pass through the lenses of our reviewer personas Novice Nate and Editor Evie.

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 17, 2026

Claude finished @Combs7th's task in 1m 14s —— View job


Review through Novice Nate and Editor Evie personas

  • Read CLAUDE.md and persona definitions
  • Read the changed file
  • Review through Novice Nate lens
  • Review through Editor Evie lens

Here's the added sentence under review:

From Mattermost server v11.6.0, DateTime dialog fields support a configurable IANA timezone for display—the picker shows the configured timezone label—and can be configured to allow manual time entry, enabling users to type exact times rather than only selecting from dropdown intervals.


Novice Nate's Lens

Nate is a self-taught IT admin who doesn't write code. A few things here would leave him confused:

  • "IANA timezone" — Nate has never heard of IANA. Without an example (e.g., America/New_York), this is undefined jargon with no anchor. Friction.
  • "dropdown intervals" — The default DateTime picker behavior (selecting from preset intervals) hasn't been introduced anywhere. Nate doesn't know what he's being contrasted against. Friction.
  • "can be configured"Who configures this? An admin? The integration developer? There's no subject, which creates silent ambiguity. Friction.
  • The sentence is dense and long, with nested em-dash parentheticals, making it hard to follow while building something. Nate would likely re-read it several times and still be unsure what he needs to do. Friction.

Editor Evie's Lens

Evie would flag a few issues here:

  1. Sentence structure is awkward. The subject shifts mid-sentence: DateTime fields support ... and can be configured to allow. Either "fields support ... and allow" (parallel active voice) or split into two clauses. As written, the grammatical subject of "can be configured to allow" is technically the fields, but it reads as if a developer or admin is doing the configuring. Friction.

  2. Em-dash nesting creates hard-to-parse prose. configurable IANA timezone for display—the picker shows the configured timezone label—and can be configured buries the parenthetical explanation between two dashes inside an already complex clause. The aside the picker shows the configured timezone label would read better as a brief inline clarification restructured into the main clause. Friction.

  3. "IANA" is undefined and unlinked. Evie would either define it inline or add a concrete example. Friction.

  4. The bullet is now very long. Appending a version-gated capability sentence to an already-long bullet means the whole entry is hard to scan. Evie might suggest moving the v11.6.0 content to a sub-bullet or its own sentence introduced more cleanly.


Suggested Revision

- `Interactive Dialogs <https://developers.mattermost.com/integrate/plugins/interactive-dialogs/>`_: Guide users to successful outcomes when interactions need structured input or confirmation (for example, "Acknowledge with note" or "Assign to user"). Improve data quality with required fields, minimum/maximum input lengths, server-driven user/channel pickers, validated defaults, inline field errors, placeholders, and help text that help users enter the right data the first time. From v11.6.0, ``DateTime`` fields support two additional options: a configurable display timezone using an IANA timezone name (such as ``America/New_York``), which labels the picker with the configured timezone, and optional manual time entry so users can type exact times instead of selecting from preset dropdown intervals.

Key changes:

  • Defines IANA with a concrete example (America/New_York)
  • Removes em-dash nesting; restructures the timezone explanation inline
  • Fixes subject consistency (support ... and ... so users can)
  • Clarifies "dropdown intervals" as "preset dropdown intervals"
  • Shortens version reference from "Mattermost server v11.6.0" to "v11.6.0" (matches convention in this file)

Fix this →

@Combs7th
Copy link
Copy Markdown
Contributor Author

@esethna - Do you think that's better now?

@Combs7th Combs7th requested a review from esethna April 17, 2026 01:05
@github-actions
Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA ccdd975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor Guidance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interactive Dialog - DateTime manual entry and timezone support

3 participants