feat(guest): replace musl with picolibc#831
Merged
jprendes merged 1 commit intohyperlight-dev:mainfrom Apr 21, 2026
Merged
Conversation
andreiltd
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
andreiltd
force-pushed
the
libc-takeover
branch
from
617d834 to
3f8ffcf
Compare
andreiltd
added
the
kind/enhancement
andreiltd
force-pushed
the
libc-takeover
branch
6 times, most recently
from
eaf1d54 to
b18a374
Compare
jprendes
reviewed
Aug 28, 2025
jprendes
reviewed
Aug 28, 2025
Contributor
|
will help with #282 |
12 tasks
andreiltd
force-pushed
the
libc-takeover
branch
5 times, most recently
from
499c59d to
2ae0a3a
Compare
jprendes
reviewed
Sep 4, 2025
andreiltd
force-pushed
the
libc-takeover
branch
from
2ae0a3a to
d3826af
Compare
andreiltd
force-pushed
the
libc-takeover
branch
from
d2043ac to
2bd1ff4
Compare
dblnz
reviewed
Mar 4, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
Great work, Tomasz!! This is one hell of a diff and I like it 😆
jprendes
reviewed
Mar 5, 2026
Member
|
Is the licensing approval finally done for this, making it ready for review/merge? |
andreiltd
force-pushed
the
libc-takeover
branch
2 times, most recently
from
cacc739 to
2fbc721
Compare
dblnz
previously approved these changes
Mar 10, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
Great work, Tomasz!
I have nothing else to add.
andreiltd
force-pushed
the
libc-takeover
branch
from
3680b58 to
20195de
Compare
andreiltd
force-pushed
the
libc-takeover
branch
from
01f8cb1 to
4daa971
Compare
ludfjig
previously approved these changes
Mar 23, 2026
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
I think this is awesome!
andreiltd
force-pushed
the
libc-takeover
branch
4 times, most recently
from
dd0725c to
689094b
Compare
jprendes
reviewed
Apr 20, 2026
Contributor
jprendes
left a comment
jprendes
left a comment
There was a problem hiding this comment.
I would like the libc stuff to go in its own crate, like hyperlight-libc.
Just my opinion, and if you agree, it doesn't need to be in this PR either, I'd rather have this in than delaying due to splitting in another crate.
andreiltd
force-pushed
the
libc-takeover
branch
from
689094b to
341b4f3
Compare
Replace musl C library with picolibc for guest binaries The picolibc submodule uses the picolibc-bsd fork (https://github.com/hyperlight-dev/picolibc-bsd), which is a redistribution with all copyleft-licensed files removed from the tree and history. Only BSD/MIT/permissive-licensed source files are present. - Switch libc implementation from musl to picolibc (vendored submodule) - Use picolibc-bsd fork with copyleft files excluded - Update build.rs to compile picolibc from source via cc crate - Add POSIX stubs for picolibc - Update documentation and NOTICE.txt Signed-off-by: Tomasz Andrzejak <andreiltd@gmail.com>
andreiltd
force-pushed
the
libc-takeover
branch
from
341b4f3 to
5517d33
Compare
This was referenced Apr 21, 2026
syntactically
approved these changes
Apr 21, 2026
|
Thank you so much for all the work on this ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes custom musl implementation used by the guest and replace it with picolibc v1.8.11.
Note: The picolibc submodule uses the picolibc-bsd fork (https://github.com/hyperlight-dev/picolibc-bsd), which is a redistribution with all copyleft-licensed files removed from the tree and history. Only BSD/MIT/permissive-licensed source files are present.