fix: Validate guest address ranges for overlapping regions in map_region#1369
Draft
Richard-Durkee wants to merge 1 commit intohyperlight-dev:mainfrom
Draft
fix: Validate guest address ranges for overlapping regions in map_region#1369Richard-Durkee wants to merge 1 commit intohyperlight-dev:mainfrom
Richard-Durkee wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
Add overlap validation to HyperlightVm::map_region to enforce the safety contract documented on VirtualMachine::map_memory, which requires that memory regions must not overlap. The check validates the new region against: - Existing dynamically mapped regions (mmap_regions) - The snapshot region (starting at BASE_ADDRESS) - The scratch region (at the top of the GPA space) Add Overlapping variant to MapRegionError with a descriptive message showing both the new and conflicting ranges. Add four tests covering: - Exact duplicate mapping rejection - Partial overlap rejection - Adjacent non-overlapping regions (should succeed) - Overlap with the snapshot region Signed-off-by: Richard Durkee <Richard-Durkee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overlap validation to HyperlightVm::map_region to enforce the safety contract documented on VirtualMachine::map_memory, which requires that memory regions must not overlap.
The check validates the new region against:
Add Overlapping variant to MapRegionError with a descriptive message showing both the new and conflicting ranges.
Add four tests covering: