Conversation
This reverts commit 7b724e0.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request completes the transition to the redesigned Flutter Inspector (V2) by removing the legacy inspector code and the option to switch back to it. The changes involve deleting numerous legacy files, updating imports across the codebase, and consolidating the V2 implementation. Feedback focuses on critical type safety issues in the settings dialog where invalid casts to ValueNotifier<bool?> could cause runtime errors, along with suggestions for import consistency and safer disposal logic in the screen controller.
There was a problem hiding this comment.
I tried to fix the test here to force the images in the memory panel legend to lad, but wasn't successful. Didn't spend too long investigating because I know image rendering is unstable in screenshot tests (see flutter/flutter#38997) but can investigate more if needed!
2 participants
Work towards #9563
Fixes #9566
This PR:
inspector_sharedfiles toinspector_v2It does not:
inspector_v2toinspector(that will be follow up to avoid over-complicating this PR)I recommend reviewing commit-by-commit since the Github diffing algorithm otherwise shows files as having been deleted and re-added when in fact they were simply moved.