fix(console): find nodejs.util.inspect.custom on Proxy objects via get trap#33265
Open
bartlomieju wants to merge 1 commit intomainfrom
Open
fix(console): find nodejs.util.inspect.custom on Proxy objects via get trap#33265bartlomieju wants to merge 1 commit intomainfrom
bartlomieju wants to merge 1 commit intomainfrom
Conversation
…t trap
Deno's console.log/inspect used `ReflectHas` (the `in` operator) to
check for `Symbol.for('nodejs.util.inspect.custom')` on objects. For
Proxy objects that override the `has` trap to hide symbols (e.g.
nodejs-polars DataFrames which use Proxy for column access), this
returned false even though the symbol was accessible via the `get` trap.
Node.js accesses the symbol directly without checking `has` first. This
commit matches that behavior by accessing the property directly and
relying on the existing `typeof === "function"` check.
Closes #33236
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deno's
console.log/Deno.inspectusedReflectHas(theinoperator) to check forSymbol.for('nodejs.util.inspect.custom'). For Proxy objects that override thehastrap to hide symbols while still exposing them viaget(e.g. nodejs-polars DataFrames), this caused the custom inspect to be skipped entirely.Node.js accesses the symbol directly without going through
has. This commit matches that behavior.Before:
console.log(df)outputs{}for a nodejs-polars DataFrameAfter:
console.log(df)outputs the formatted table (via the custom inspect method)Test plan
inspectProxyWithNodeCustomInspect— Proxy that hides symbols fromhas/ownKeysbut exposes viagetinspectProxytests pass (including the throwing-get-trap case)tools/format.js,tools/lint.js --jscleanCloses #33236
🤖 Generated with Claude Code