fix: address review feedback on telemetry infrastructure (#325 follow-up)#361
Closed
samikshya-db wants to merge 2 commits intomainfrom
Closed
fix: address review feedback on telemetry infrastructure (#325 follow-up)#361samikshya-db wants to merge 2 commits intomainfrom
samikshya-db wants to merge 2 commits intomainfrom
Conversation
…-up) - Route DatabricksTelemetryExporter and FeatureFlagCache HTTP through shared connection stack (connectionProvider.getRetryPolicy().invokeWithRetry) matching CloudFetchResultHandler pattern; remove bespoke retry loops - Fix HALF_OPEN concurrent-probe race in CircuitBreaker with atomic tryAdmit check-and-set - Fix MetricsAggregator.close() flush race: async close with closing flag suppresses intermediate batch flushes; single awaited flush drains remaining metrics - Simplify telemetryUtils to minimal SSRF-safe URL builder; remove unused helpers - Clean up types, exports, and test coverage across telemetry modules Co-authored-by: samikshya-chand_data
Co-authored-by: samikshya-chand_data
samikshya-db
requested a deployment
to
azure-prod
GitHub Actions
Waiting
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #325. Addresses all pending review feedback on the telemetry infrastructure layer.
DatabricksTelemetryExporter.sendRequestandFeatureFlagCache.fetchFeatureFlagnow route throughconnectionProvider.getRetryPolicy().invokeWithRetry(), matching theCloudFetchResultHandlerpattern — removes bespoke retry loops and rawnode-fetchcallstryAdmit), preventing multiple simultaneous probesMetricsAggregator.close()flush race:close()is nowasync; aclosingflag suppresses intermediate batch-triggered fire-and-forget flushes so a singleawait this.flush(false)drains all remaining metrics cleanlytelemetryUtils: simplified to a minimal SSRF-safe URL builder; removed unused helpersTest plan
coverage/excluded from git trackingThis pull request was AI-assisted by Isaac.