Skip to content

Truncate file lists in maintainer-approval comments#4998

Merged
simonfaltum merged 1 commit intomainfrom
simonfaltum/truncate-file-lists
Apr 16, 2026
Merged

Truncate file lists in maintainer-approval comments#4998
simonfaltum merged 1 commit intomainfrom
simonfaltum/truncate-file-lists

Conversation

@simonfaltum
Copy link
Copy Markdown
Member

Why

The maintainer-approval bot comments list every single file in each ownership group. For PRs that touch many files (e.g. codegen updates), this makes the comment extremely verbose and hard to scan.

Changes

When an ownership group has 4 or more files, the comment now shows "N files changed" instead of listing every file path. Groups with fewer than 4 files still list them individually.

Test plan

  • Added test for < 4 files (individual listing preserved)
  • Added test for >= 4 files (count shown instead)
  • All 22 tests pass: node --test .github/workflows/maintainer-approval.test.js

This pull request was AI-assisted by Isaac.

Show "N files changed" instead of listing every file when a group
has 4 or more files. Groups with fewer than 4 files still list
them individually.

Co-authored-by: Isaac
@simonfaltum simonfaltum enabled auto-merge April 16, 2026 15:05
@simonfaltum simonfaltum added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 0341df8 Apr 16, 2026
26 checks passed
@simonfaltum simonfaltum deleted the simonfaltum/truncate-file-lists branch April 16, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants