fix(test): wrap flaky homepage tests in travel_to blocks

[mroderick]

Summary

Fixes a flaky test failure in spec/features/visiting_homepage_spec.rb that was causing intermittent CI failures.

Problem

The test scenario "i can view the next 5 upcoming events" was failing intermittently in CI with the following error:

expected to find text "Rerum sed quia assumenda. at Ghislaine Treutel DO" in "..."

The events were not appearing on the homepage because they were being filtered out by the upcoming scope.

Root Cause

This is a time synchronization issue between fabricator timestamps and database scope queries:

1. Fabricator timestamps are evaluated when the file loads:

   # spec/fabricators/event_fabricator.rb
   date_and_time Time.zone.now + 2.days  # Evaluated at FILE LOAD time

2. The upcoming scope compares against Time.zone.now at query time:

   # app/models/concerns/listable.rb
   scope :upcoming, -> { where('date_and_time >= ?', Time.zone.now) }

3. The controller's all_events method uses the upcoming scope:

   # app/controllers/dashboard_controller.rb
   events = Event.upcoming.take(DEFAULT_UPCOMING_EVENTS)

When time passes between fabricator file loading and test execution, events created with Time.zone.now + 2.days at file load time may actually be in the past relative to Time.zone.now at query time, causing them to be filtered out.

Solution

Wrap time-dependent test scenarios in travel_to(Time.current) blocks to freeze time:

scenario 'i can view the next 5 upcoming events' do
  travel_to(Time.current) do
    events.take(5).each { |event| expect(page).to have_content "#{event.name} at #{event.venue.name}" }
  end
end

This ensures both the fabricator timestamps and the scope queries use the same time reference.

Related Work

This follows the same pattern as commit 3f44835e ("fix(test): freeze time in tests to prevent flaky failures") which resolved similar flaky tests in 15 other files:

• spec/features/listing_events_spec.rb
• spec/features/chapter_spec.rb
• spec/models/concerns/listable_spec.rb
• And 12 others...

The visiting_homepage_spec.rb file was missed in that earlier fix.

Files Changed

• spec/features/visiting_homepage_spec.rb - Added travel_to blocks around time-dependent scenarios

Testing

• Test now consistently passes when time is frozen
• Follows established pattern from previous flaky test fixes
• No production code changes

References

• Previous flaky test fix: 3f44835e
• Rails travel_to documentation: https://api.rubyonrails.org/classes/ActiveSupport/Testing/TimeHelpers.html