Conversation
mroderick
force-pushed
the
chore/add-fallow
branch
2 times, most recently
from
5adf133 to
7447368
Compare
Collaborator
Author
|
Fixes #2 |
till
previously approved these changes
Apr 18, 2026
…lication Extract duplicated POST request logic in magic-links.test.js into a standalone helper function. The same 9-line block appeared in two tests for requesting magic links. Fallow report (before): test/features/magic-links.test.js:11-24 test/features/magic-links.test.js:34-48 15 lines duplicated across 2 instances Fallow report (after): ✓ No code duplication found
Add fallow static analysis tool to catch dead code, duplication, and complexity issues: - Add fallow ^2.40.3 to devDependencies - Add npm run fallow script (runs dead-code, dupes, health) - Integrate into smoke test job in CI workflow This allows Dependabot to keep fallow updated and ensures all code quality checks run on every PR. All current fallow checks pass: - Dead code: No issues - Duplicates: No duplication - Health: 92 A score
mroderick
force-pushed
the
chore/add-fallow
branch
from
7447368 to
09ddb50
Compare
Collaborator
Author
|
Hmm .. stacked PRs and requiring a review on every final commit in a branch means re-reviewing things ... sorry about that. I'll try to not make stacked PRs to avoid this |
till
approved these changes
Apr 18, 2026
Collaborator
|
It's fine, Github showed me what I have to look at. Aka zero new changes. |
mroderick
added a commit
that referenced
this pull request
Apr 18, 2026
chore: add fallow static analysis to CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been branched from #8, please review and merge that one first :)
Summary
Integrates fallow static analysis into the project and CI pipeline to catch dead code, duplication, and complexity issues.
Changes
Package.json
fallowas devDependency (^2.40.3)npm run fallowscriptCI Workflow
npm run fallowto smoke test jobCurrent Status
All fallow checks currently pass:
Why This Matters
Fallow catches:
Running in CI ensures these issues don't creep back in.
Notes
.fallowrc.jsonconfiguration