chore(repo): upgrade monorepo to Node.js 24 by jacekradko · Pull Request #8351 · clerk/javascript

jacekradko · 2026-04-18T03:45:53Z

Summary

Upgrades the monorepo development environment to Node.js 24
Maintains Node ≥20.9.0 compatibility for published packages
Updates CI workflows to test both Node 24 and Node 20

Changes

Updated root package.json engines to require Node ≥24.15.0
Updated .nvmrc to Node 24.15.0
Updated CI workflows to use Node 24 as primary version
Added Node 20 to CI test matrix for published package compatibility
Updated release workflow caching to Node 24

Test plan

Build passes with Node 24
Tests pass with Node 24
Published packages still work with Node 20 (with expected engine warnings)
CI configuration updated to test both versions

- Update root package.json engines to require Node >=24.15.0 - Update .nvmrc to Node 24.15.0 - Update CI workflows to use Node 24 as primary version - Add Node 20 to CI test matrix for published package compatibility - Update release workflow caching to Node 24 Published packages maintain Node >=20.9.0 compatibility as specified in their individual engines fields. This change only affects the monorepo development environment and CI/CD pipelines.

changeset-bot · 2026-04-18T03:45:59Z

🦋 Changeset detected

Latest commit: a14d934

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@clerk/backend	Patch
@clerk/react-router	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/hono	Patch
@clerk/nextjs	Patch
@clerk/nuxt	Patch
@clerk/tanstack-react-start	Patch
@clerk/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-04-18T03:45:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	Apr 23, 2026 3:01am

coderabbitai · 2026-04-18T03:48:07Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.json engines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check	✅ Passed	The description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-04-18T03:48:32Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8351

commit: a14d934

vercel · 2026-04-20T21:53:31Z

Deployment failed with the following error:

You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication

- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node - In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects - Also fixes a latent precedence bug where a provided init was silently dropped

- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied - Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc

📥 Commits

Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.

📒 Files selected for processing (4)

.github/actions/init-blacksmith/action.yml
.github/actions/init/action.yml
.github/workflows/ci.yml
packages/backend/src/tokens/clerkRequest.ts

🚧 Files skipped from review as they are similar to previous changes (3)

.github/actions/init-blacksmith/action.yml
.github/actions/init/action.yml
packages/backend/src/tokens/clerkRequest.ts

coderabbitai · 2026-04-22T02:54:22Z

+          - node-version: 24.15.0
+            test-filter: "**"
+            filter-label: "**"
+          - node-version: 20


⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash set -euo pipefail echo "CI matrix node versions:" rg -n -C2 'node-version:' .github/workflows/ci.yml echo echo "Repo engine + local Node baseline:" rg -n '"node":\s*">=24\.15\.0"' package.json sed -n '1,5p' .nvmrc echo echo "Verify init action wiring for node-version input:" fd -i 'action.yml' .github/actions/init-blacksmith --exec rg -n -C2 'inputs:|node-version|setup-node' {}

Repository: clerk/javascript

Length of output: 1501

🏁 Script executed:

cat package.json | head -20

Repository: clerk/javascript

Length of output: 1266

🏁 Script executed:

# Search for any documentation about Node version support fd -i 'readme|contributing' --type f | head -5 | xargs grep -l -i 'node' 2>/dev/null || echo "No matches in readme files"

Repository: clerk/javascript

Length of output: 108

🏁 Script executed:

# Check if there are any comments or issues in the workflow itself about Node 20 support rg -B5 -A5 'node-version: 20' .github/workflows/ci.yml

Repository: clerk/javascript

Length of output: 315

🏁 Script executed:

cat docs/CONTRIBUTING.md | grep -i -A5 -B5 'node\|version' | head -40

Repository: clerk/javascript

Length of output: 1880

Remove Node 20 from the CI matrix—it falls below the minimum supported version

The CI matrix tests node-version: 20 (line 224), but the repository's minimum supported version is 24.15.0, as declared in package.json ("node": ">=24.15.0") and documented in .nvmrc and CONTRIBUTING.md. Node 20 does not meet this requirement and should be removed from the matrix entirely.

Proposed change

- node-version: 24.15.0 test-filter: "**" filter-label: "**" - - node-version: 20 - test-filter: "**" - filter-label: "**"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

- node-version: 24.15.0

test-filter: "**"

filter-label: "**"

- node-version: 20

- node-version: 24.15.0

test-filter: "**"

filter-label: "**"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 221 - 224, CI matrix includes an unsupported "node-version: 20" entry; remove that entry so the matrix only contains the supported "node-version: 24.15.0". Edit the matrix block that lists the node-version values (the YAML key "node-version" in the job matrix) and delete the line with "20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label" entries unchanged); verify no other job or matrix elsewhere still references node 20.

Keeping the Node 20 entry intentionally — every published package still declares "engines": { "node": ">=20.9.0" }, so testing against the lowest supported runtime catches regressions for consumers on Node 20. The root >=24.15.0 is a dev/build requirement only, and engine-strict=false in .npmrc lets pnpm install proceed regardless. Pinned the matrix to 20.9.0 exactly so we're testing the actual minimum supported version.

@jacekradko, that makes complete sense — thank you for the clarification. The distinction between the root engines.node (a dev/build tooling requirement) and the individual published packages' engines.node (the consumer-facing minimum) is an important one, and I missed it. Testing against Node 20.9.0 in CI is exactly the right way to guard against regressions for downstream consumers on the lowest supported runtime. I'll update my understanding for future reviews.

✏️ Learnings added

Learnt from: jacekradko Repo: clerk/javascript PR: 8351 File: .github/workflows/ci.yml:0-0 Timestamp: 2026-04-23T02:41:47.066Z Learning: In the clerk/javascript monorepo, the root `package.json` `engines.node` (currently `>=24.15.0`) is a dev/build tooling requirement only. Individual published packages declare their own `engines.node` (currently `>=20.9.0`), which represents the minimum supported consumer runtime. The CI `unit-tests` matrix intentionally includes Node 20.9.0 to catch regressions for consumers on the lowest supported version. `engine-strict=false` in `.npmrc` allows pnpm install to proceed regardless of engine version. Do not flag Node 20.x CI matrix entries as unsupported — they are testing published-package consumer compatibility, not the dev environment requirement.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

…n compat

jacekradko added 2 commits April 17, 2026 22:45

chore: add changeset for Node 24 upgrade

d50f674

github-actions Bot added the actions label Apr 18, 2026

vercel Bot deployed to Preview April 18, 2026 03:46 View deployment

Merge branch 'main' into jacek/upgrade-to-node-24

6d4945a

vercel Bot deployed to Preview April 20, 2026 13:23 View deployment

Merge branch 'main' into jacek/upgrade-to-node-24

9bf6afa

Merge branch 'main' into jacek/upgrade-to-node-24

711329c

vercel Bot deployed to Preview April 21, 2026 23:13 View deployment

jacekradko changed the title ~~chore: upgrade monorepo to Node.js 24~~ chore(repo): upgrade monorepo to Node.js 24 Apr 22, 2026

github-actions Bot added the backend label Apr 22, 2026

vercel Bot deployed to Preview April 22, 2026 02:11 View deployment

vercel Bot deployed to Preview April 22, 2026 02:50 View deployment

coderabbitai Bot reviewed Apr 22, 2026

View reviewed changes

fix(react-router): omit signal from patchRequest clone for Node 24

8d74519

github-actions Bot added the react-router label Apr 22, 2026

vercel Bot deployed to Preview April 22, 2026 02:59 View deployment

fix(backend): satisfy curly lint rule in ClerkRequest signal proxy

8619779

vercel Bot deployed to Preview April 22, 2026 03:24 View deployment

ci(repo): pin minimum-supported Node 20.9.0 in unit-test matrix

b736bc2

vercel Bot deployed to Preview April 23, 2026 02:41 View deployment

ci(repo): bump unit-test Node 20 matrix to 20.19.0 for build toolchai…

a14d934

…n compat

vercel Bot deployed to Preview April 23, 2026 03:01 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(repo): upgrade monorepo to Node.js 24#8351

chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko wants to merge 11 commits intomainfrom
jacek/upgrade-to-node-24

jacekradko commented Apr 18, 2026

Uh oh!

changeset-bot Bot commented Apr 18, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Apr 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 18, 2026 •

edited

Loading

Reviews paused

Walkthrough

Estimated code review effort

Uh oh!

pkg-pr-new Bot commented Apr 18, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Apr 20, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Apr 22, 2026 •

edited

Loading

Uh oh!

jacekradko Apr 23, 2026

Uh oh!

coderabbitai Bot Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jacekradko commented Apr 18, 2026

Summary

Changes

Test plan

Uh oh!

changeset-bot Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Estimated code review effort

Uh oh!

pkg-pr-new Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Apr 20, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacekradko Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot Bot commented Apr 18, 2026 •

edited

Loading

vercel Bot commented Apr 18, 2026 •

edited

Loading

coderabbitai Bot commented Apr 18, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 18, 2026 •

edited

Loading

coderabbitai Bot Apr 22, 2026 •

edited

Loading