docs(repo): Revise and clarify isLoaded description and tab title#8336
docs(repo): Revise and clarify isLoaded description and tab title#8336SarahSoutoul wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2370534 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated JSDoc for the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
…s that actually revert Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
Pushed some refinements directly in 2370534.
LMK if any of this feels wrong to you. |
|
Separate thread: the PR title mentions "and tab title" and the Linear ticket specifically calls out Current labels:
"Loading" would be my suggestion — maps directly to |
Description
Linear ticket: https://linear.app/clerk/issue/DOCS-11007/revise-and-clarify-isloaded-description-and-tab-title
This PR updates the description of
isLoadedacross hooks (useAuth, useUser, useSession, etc.) to better reflect its actual behavior.Previously, the docs described
isLoadedas:“Initially false, becomes true once Clerk loads.”
This wording implies a one-time initialization phase. In practice,
isLoadedrepresents whether the current authentication state is resolved, and can temporarily revert to false during auth updates (e.g. when switching organizations via setActive).Here are the changes I applied:
falseand becomestrueonce loaded BUT may temporarily return tofalsewhile auth state is updatingChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change