Fix icon async test warnings and align component typing style#555
Open
flacoman91 wants to merge 10 commits intomainfrom
Open
Fix icon async test warnings and align component typing style#555flacoman91 wants to merge 10 commits intomainfrom
flacoman91 wants to merge 10 commits intomainfrom
Conversation
flacoman91
requested review from
anselmbradford,
billhimmelsbach,
contolini and
natalia-fitzgerald
as code owners
|
…pbTagline. * Tightened @cfpb/cfpb-design-system/src/components/cfpb-expandables types to include Summary, SummaryMinimal, and *Styles, with correct init signatures. * Removed unknown casts in summary.tsx, expandable-group.tsx, banner.tsx, and tagline.test.tsx. * Adjusted Tagline stories to use name instead of storyName and satisfies Meta<...> for safe typing. * Fixed Expandable stories args typing without relying on the global React namespace.
flacoman91
changed the title
…, eliminating hydration warnings in TextIntroduction and Well call‑to‑action lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went in to clean up warnings being thrown in CE and CCDB jest tests related to icons getting loaded async and went down a rabbit hole of fixing other warnings and nags:
<li>rendering by treating ListLink as already wrapped, eliminating hydration warnings in TextIntroduction and Well call‑to‑action lists.Verification of this requires a dev to run their own tests in their own app. these warnings should not be there anymore.