fix: auto-detect CMake vs autotools for warnet image build#801
Open
b-l-u-e wants to merge 1 commit intobitcoin-dev-project:mainfrom
Open
fix: auto-detect CMake vs autotools for warnet image build#801b-l-u-e wants to merge 1 commit intobitcoin-dev-project:mainfrom
b-l-u-e wants to merge 1 commit intobitcoin-dev-project:mainfrom
Conversation
Contributor
|
rebased on main and tweaked a few things: https://github.com/pinheadmz/warnet/tree/fix/769-warnet-image-build-cmake-autotools If you allow maintainers to edit your branch I can just push my suggestions |
pinheadmz
reviewed
Apr 22, 2026
| Probes the GitHub raw content URL for CMakeLists.txt at the given commit. | ||
| Returns 'cmake' if found, 'autotools' otherwise. | ||
| """ | ||
| url = f"https://raw.githubusercontent.com/{repo}/{commit_sha}/CMakeLists.txt" |
Contributor
There was a problem hiding this comment.
I dont think this works. did you test it? provide examples please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warnet image buildnow chooses the Bitcoin Core build path automatically:CMakeLists.txtexists at the given ref onraw.githubusercontent.com-Dockerfile.cmakeand default CMakeBUILD_ARGS.Dockerfile.autotoolsand default autotoolsBUILD_ARGS.Users can still override with
--build-args.docker-bake.hcland the Docker bake section fromdocs/developer-notes.mdin favor of on-the-fly builds via the CLI.Dockerfiles
Dockerfile→Dockerfile.autotools,Dockerfile.dev-Dockerfile.cmake.git fetch, usegit checkout FETCH_HEADso tags (e.g.v26.0) work (Dockerfile.cmake,Dockerfile.autotools,insecure/Dockerfile).alpine:3.20; set Berkeley DBLDFLAGS/CPPFLAGSonly when/opt/db-*exists.Testing
warnet image buildwithbitcoin/bitcoin,--commit-sha master(cmake) andv26.0(autotools),--arches amd64,--action loadboth produced loadable images locally.This Closes #769.