sdk-core, node: In memory proper attribute filtering#368
Open
konraddysput wants to merge 1 commit intomainfrom
Open
sdk-core, node: In memory proper attribute filtering#368konraddysput wants to merge 1 commit intomainfrom
konraddysput wants to merge 1 commit intomainfrom
Conversation
konraddysput
requested review from
GT1990,
adamcronin42,
melekr,
perf2711 and
rick-bt
GT1990
approved these changes
Apr 20, 2026
perf2711
reviewed
Apr 21, 2026
Comment on lines
+236
to
+245
| const unknownValue = value as unknown; | ||
| try { | ||
| if (unknownValue instanceof Date) { | ||
| result[key] = unknownValue.toISOString(); | ||
| } else if (unknownValue instanceof URL) { | ||
| result[key] = unknownValue.toString(); | ||
| } | ||
| } catch { | ||
| // revoked proxy or broken object — drop it | ||
| } |
Contributor
There was a problem hiding this comment.
If you would extract switch to a separate method, you could try/catch for result[key] = prepareSingleAttribute(unknownValue.toJSON());, if toJSON method is available. URL and Date return toString() and toISOString() respectively under toJSON, so you would have them handled, and potentially other things.
Be sure to limit the depth in case of toJSON returning a value that is the same object, or also a value that has a toJSON function.
Collaborator
Author
There was a problem hiding this comment.
limitObjectDepth should be enough. I removed this change because the problem was existing somewhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Per @GT1990 comment, InMemoryAttributes are not covered. Therefore, I decided to move the implementation to the BreacrumbManager and always pass prepared attributes to the storage.