Conversation
🤖 Augment PR SummarySummary: Refactors Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
Owner
Author
|
augment review |
Owner
Author
|
augment review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- By @avoidwork --
Summary
Refactor
filesize()to extract responsibility into dedicated delegate functions, improving adherence to SOLID principles (specifically SRP - Single Responsibility Principle).Changes
helpers.js:calculateExponent(),applyRounding(),resolveSymbol(),decorateResult(),formatOutput()filesize()from 285 to 242 lines with clear pipeline of delegate callsBefore
filesize()handled: validation, base config, exponent calculation, rounding, auto-increment, precision, symbol lookup, negation, custom symbols, locale/separator/padding formatting, full names, and output dispatch -- ~14 responsibilities.After
filesize()sequences delegates:validate → getBaseConfig → handleZero → calculateExponent → calculateOptimizedValue → applyRounding → applyPrecision → resolveSymbol → decorateResult → formatOutput.