Added read/write timeout support to Rust TTcpChannel#3399
Open
ShemShadrack wants to merge 1 commit intoapache:masterfrom
Open
Added read/write timeout support to Rust TTcpChannel#3399ShemShadrack wants to merge 1 commit intoapache:masterfrom
ShemShadrack wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Can we have a JIRA ticket for this one pls? |
Jens-G
requested changes
Apr 19, 2026
| log = "0.4" | ||
| uuid = "1" | ||
| uuid = ">=1, <1.21" | ||
|
|
Member
There was a problem hiding this comment.
Why do we want to do that? If there is an incompatibility with >= 1.21, the proper approach would be to fix the incompatibility.
-1 I'm against it. Even more as the change is not explained at all.
| stream: Some(stream), | ||
| read_timeout: None, | ||
| write_timeout: None, | ||
| } |
Member
There was a problem hiding this comment.
The incoming stream may have timeouts configured. This gives an inconsistent state.
|
|
||
| /// Set the read and write timeouts for this channel. | ||
| pub fn set_timeouts( | ||
| &mut self, |
Member
There was a problem hiding this comment.
Should we also have getters to make it complete?
Member
|
BTW We still look for Rust maintainers as the previous one got lost somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add timeout configuration support to the Rust TTcpChannel.
This change adds:
Timeouts are applied immediately when the channel already wraps an open
TcpStream, and cached for later application when the channel is opened
after configuration.
Testing
Verified with:
Added unit tests covering: