Skip to content

fix(ci): drop review requirement from Mergify for single-maintainer workflow#1362

Merged
jeremyeder merged 2 commits intoambient-code:mainfrom
jeremyeder:fix/mergify-single-maintainer
Apr 20, 2026
Merged

fix(ci): drop review requirement from Mergify for single-maintainer workflow#1362
jeremyeder merged 2 commits intoambient-code:mainfrom
jeremyeder:fix/mergify-single-maintainer

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

@jeremyeder jeremyeder commented Apr 20, 2026

Summary

  • Remove approval gates from merge queue — PRs merge on green CI without human review
  • Remove large-pr queue (no tiered review needed with one maintainer)
  • Keep CI gates, changes-requested block, dependabot auto-approval, auto-rebase

This is the first PR that should auto-merge itself once CI passes.

Test plan

  • This PR auto-merges when CI passes (no approval needed)
  • Requesting changes on a subsequent PR blocks the merge

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Simplified pull request queueing by consolidating rules and reducing extra approval gating for smoother merge flow.
    • Minor runtime invocation tweak to improve subprocess handling reliability.
  • Tests

    • Adjusted a subprocess-related test invocation to more robustly exercise large-output behavior.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 20, 2026

Deploy Preview for cheerful-kitten-f556a0 ready!

Name Link
🔨 Latest commit 2685b44
🔍 Latest deploy log https://app.netlify.com/projects/cheerful-kitten-f556a0/deploys/69e662a4d86c7000088a4d5e
😎 Deploy Preview https://deploy-preview-1362--cheerful-kitten-f556a0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1aa6ca64-58c0-4061-8b58-655307516e93

📥 Commits

Reviewing files that changed from the base of the PR and between 9a62947 and 2685b44.

📒 Files selected for processing (3)
  • .mergify.yml
  • components/runners/ambient-runner/ambient_runner/bridges/gemini_cli/session.py
  • components/runners/ambient-runner/tests/test_gemini_session.py
✅ Files skipped from review due to trivial changes (3)
  • components/runners/ambient-runner/ambient_runner/bridges/gemini_cli/session.py
  • .mergify.yml
  • components/runners/ambient-runner/tests/test_gemini_session.py

📝 Walkthrough

Walkthrough

Mergify queue rules simplified by removing the dedicated large-pr rule and consolidating size-based routing into a single default rule; small edits in the Gemini CLI session code and its test adjust how subprocess arguments and the limit expression are written without changing behavior.

Changes

Cohort / File(s) Summary
Mergify configuration
.mergify.yml
Removed large-pr queue and its size/approval gates; merged size-based queueing into one rule that enqueues non-draft, non-conflicting PRs to default; removed the extra #approved-reviews-by>=1 requirement from default.
Gemini CLI session & tests
components/runners/ambient-runner/ambient_runner/bridges/gemini_cli/session.py, components/runners/ambient-runner/tests/test_gemini_session.py
Reformatted subprocess stream limit expression to 10 * 1024 * 1024 across multiple lines and split python3 invocation arguments in the test into separate parameters; no behavioral or control-flow changes.
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title follows Conventional Commits format (type: fix, scope: ci) and clearly describes the main change: removing Mergify approval requirements for single-maintainer workflow.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Performance And Algorithmic Complexity ✅ Passed PR contains only cosmetic changes with no algorithmic complexity regressions; subprocess limit 10MB, bounded buffers with deque(maxlen), 60-second worker TTL, proper timeout handling, no N+1 patterns or unbounded growth.
Security And Secret Handling ✅ Passed PR contains no security violations. Subprocess invocations are safe with arguments as lists, sensitive env vars filtered via blocklist, API keys never logged directly, and test fixtures use dummy values.
Kubernetes Resource Safety ✅ Passed Kubernetes Resource Safety check is not applicable. PR modifies only CI/CD configuration and Python code without any Kubernetes manifests or resource definitions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

Ambient Code Bot and others added 2 commits April 20, 2026 13:29
…orkflow

Remove approval gates from merge queue — PRs now merge on green CI
without requiring a human review. Single maintainer means the review
requirement just creates stale PRs and admin-merge bypasses.

Changes:
- Remove large-pr queue (no tiered review needed)
- Remove #approved-reviews-by conditions
- Keep CI gates (E2E, validate-manifests, test-local-dev-simulation)
- Keep changes-requested block (can still block PRs via review)
- Simplify PR routing to single queue

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jeremyeder jeremyeder force-pushed the fix/mergify-single-maintainer branch from 9a62947 to 2685b44 Compare April 20, 2026 17:30
@jeremyeder jeremyeder merged commit 720df31 into ambient-code:main Apr 20, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant