fix: Cmd+W closing wrong window when Settings is open#802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandActionsRegistry.shared.currentinwindowDidResignKeyso stale main-window actions don't persist when a non-main window (Settings, Welcome) becomes keyresolvedCloseTabActionsalready coversRoot cause
CommandActionsRegistrywas only cleared onwindowWillClose, not onwindowDidResignKey. When the user opened Settings (Cmd+,) from a main editor window, the registry retained the main window'scommandActions. Pressing Cmd+W then resolved those stale actions viaresolvedCloseTabActionsand calledcloseTab()on the main window instead of closing the Settings window.Test plan