Draft
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
First step in the Hydrogen modularization effort. This adds the hydrogen-core micro-package for shared, framework-agnostic constants and utilities that are currently duplicated across hydrogen, hydrogen-react, and cli-hydrogen. - Register hydrogen-core in pnpm workspace - Add @types/node to root devDependencies (resolves root tsconfig) - Scaffold package with tsup build, vitest, and tsconfig - Seed with isMockShop utility + tests as proof-of-scaffold Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
fredericoo
force-pushed
the
fb-scaffold-micropackage
branch
from
d1a392a to
f8ca0dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Scaffolding basic core separate package for internal usage
WHAT is this pull request doing?
New package:
@shopify/hydrogen-corepackages/hydrogen-core/with tsup build, vitest, and tsconfigMOCK_SHOP_DOMAIN,isMockShop) — the kind of utility currently duplicated across hydrogen, hydrogen-react, and cliMonorepo housekeeping
@types/node(via catalog) to rootdevDependenciesso the root tsconfig resolves cleanlyHOW to test your changes?
pnpm install && pnpm buildpnpm test— all existing tests should pass at their new pathscd packages/hydrogen-core && pnpm buildChecklist