Open
Conversation
TOEL2
reviewed
Apr 22, 2026
| --env="$TARGET_ENVIRONMENT" \ | ||
| --token="$TESTS_TOKEN" \ | ||
| --regression_test_repo_tag "$VERSION_NUMBER" | ||
| if: ${{ (inputs.ENVIRONMENT != 'prod') && (inputs.ENVIRONMENT != 'ref') }} |
Contributor
There was a problem hiding this comment.
I understand why not prod but why not ref?
Contributor
There was a problem hiding this comment.
ohh wait are you just making sure people dont put ref when they mean preprod?
Collaborator
Author
There was a problem hiding this comment.
good spot, amended
Collaborator
Author
There was a problem hiding this comment.
actually, i copied the 'ref' reference from the old code, it looks to be 'defensive' but we don't actually pass ref at any point as the environment. So removing the ref/preprod entirely
TOEL2
previously approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switching out the PAT token usage for a workflow calling approach for regression tests
Context
PAT tokens are linked to users - we don't want this as it results in failures when people leave projects. The alternative approach is to set up permission for this repo to call the regression test repo
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.