Open
Conversation
Fix http.Request.Query() call (should be r.URL.Query()) and replace an out-of-scope variable reference with nil in the login failure tracking call. JJ-Change-Id: syznml
RomainMuller
commented
Apr 17, 2026
|
|
||
| // Track failed login | ||
| appsec.TrackUserLoginFailure(r.Context(), req.Username, true, metadata) | ||
| appsec.TrackUserLoginFailure(r.Context(), req.Username, true, nil) |
Contributor
Author
There was a problem hiding this comment.
There is no metadata in scope here... Using nil here is valid... We could also have introduced a metadata variable there alternatively. I think both approaches are valid for the sake of the example.
Contributor
Preview links (active after the
|
brett0000FF
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Fixes two errors in the Go SDK code sample:
r.Query()tor.URL.Query()(http.Requesthas no.Query()method).metadatavariable reference in the login failuretracking call with
nil.Merge instructions
Merge readiness:
Additional notes