Conversation
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
Reviewed the EdDSA MPS implementation against the ECDSA DKLS conventions. Behavior looks correct; leaving inline notes on drifts we should close before merging. Retrofit is expected to come later — not flagged.
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
Test coverage notes — the happy path and one failure branch are covered, but several explicit invariants in the production code are untested. Inline suggestions below.
Marzooqa
force-pushed
the
WCI-5
branch
2 times, most recently
from
c8889ca to
9ff9752
Compare
TICKET: WCI-5 fix(sdk-core): address PR review comments on EdDSA MPCv2 key gen - Re-export EddsaMPCv2KeyGenSendFn, KeyGenSenderForEnterprise, and MPCv2 types from eddsa index to match ECDSA export pattern - Add reducedEncryptedPrv round-trip assertions to createParticipantKeychain tests to catch regressions in btoa browser-safe encoding path - Seed bitgoMPCv2PublicGpgKey in fallback test to fix fire-and-forget constructor race with beforeEach nock setup Co-Authored-By: Claude Sonnet 4.6 <[email protected]> TICKET: WCI-5
zahin-mohammad
approved these changes
Apr 17, 2026
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
All review feedback addressed apart from the feature-flag fallback test, which can ship as a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements EddsaMPCv2Utils in sdk-core — the SDK orchestrator for EdDSA DKG using the MPS protocol.
Changes
sdk-lib-mpc — PGP comms layer
sdk-core — Key generation
EddsaMPCv2Utilswith a 2-round createKeychains flow: generatesEd25519/X25519 GPGkeys for user and backup, runsEddsaMPSDkg.DKGfor each party, PGP-signs and exchanges messages over POST/mpc/generatekey(MPS-R1, MPS-R2), verifies BitGo's signed responses, cross-checks the derived commonPublicKey, then persists all three keychains.MPSKeyGenSenderForEnterprisesender withtype: MPCv2,keyCurve: EdDSA.bitgo — Unit tests
TICKET: WCI-5