DX Improvements to arcade deploy CLI Command#811
Draft
EricGustin wants to merge 5 commits intomainfrom
Draft
Conversation
- Fix .env search to use project_root instead of CWD - Detect .py positional arg and suggest --entrypoint - Remove main.py and __main__.py from entrypoint auto-discovery (too ambiguous/unrunnable) - Warn when pyproject.toml lacks [project].name - Add MAX_PROJECT_ROOT_SEARCH_DEPTH rationale comment - Reject non-existent explicit project_dir before walking upward - Fix start_server_process callers missing project_root in test_windows_subprocess.py
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
The full-template layout uses <pkg>/__main__.py as its entrypoint. Running it via the project venv (found by find_python_interpreter) works because uv sync installs the package into .venv, making the package import resolve correctly.
- Fixed: explicit project_dir now requires pyproject.toml in that directory instead of silently walking upward to a parent project - Dismissed: __main__.py discovery (already handled), src/ layout support (feature request), Poetry name support (feature request), name normalization (standard behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.