Include actuated state into active_keys#11
Draft
girlglock wants to merge 3 commits intoAnalogSense:senpaifrom
Draft
Include actuated state into active_keys#11girlglock wants to merge 3 commits intoAnalogSense:senpaifrom
girlglock wants to merge 3 commits intoAnalogSense:senpaifrom
Conversation
Member
|
I mean, this information is certainly interesting, but it's Wooting-only so the already-existing APIs for gleaming digital keyboard input are going to be more useful regardless. |
Contributor
Author
|
my thought process for this was: "why coordinate two different apis if we can have two birds with one stone" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we can get the actuated state from the interface it would be useful to also include it into active_keys
0 for not actuated, 1 for actuated and null/undefined for when its not supported (it might need a more clever type for easier handling)
however there is still a bit of work to be done that i didnt yet figure out... we need a way to differentiate from it being available via analog interface v2 or not since turning off rapid trigger via wootility will make
packed & 0x1result in either 0 or 1 unrelated to the actuation (im assuming that its being used for something else with rt off)