Description
While working on packaging Sherlock 0.16.0 for Debian, I noticed that by default it fetches data.json from GitHub instead of using the local file installed with the package. Also, honor_exclusions=True triggers an additional network request.
In Debian, we generally try to avoid implicit network access when the same data is already available locally (such as bundled data files).
There is already the --local flag, which addresses this, but since it’s not the default, users (and automated environments/tests) may still encounter unexpected network access.
We were considering handling this downstream (e.g. with a wrapper script adding --local, or by patching the default behavior), but before doing that we thought it would be better to check with upstream.
Code of Conduct
Description
While working on packaging Sherlock 0.16.0 for Debian, I noticed that by default it fetches data.json from GitHub instead of using the local file installed with the package. Also,
honor_exclusions=Truetriggers an additional network request.In Debian, we generally try to avoid implicit network access when the same data is already available locally (such as bundled data files).
There is already the
--localflag, which addresses this, but since it’s not the default, users (and automated environments/tests) may still encounter unexpected network access.We were considering handling this downstream (e.g. with a wrapper script adding
--local, or by patching the default behavior), but before doing that we thought it would be better to check with upstream.Code of Conduct