Summary
Passing a non-numeric timeout to the CLI currently raises a raw ValueError from float(value) instead of surfacing an argparse validation error.
Reproduction
sherlock --timeout abc testuser
Current behavior
The CLI blows up while parsing arguments instead of reporting a normal argument --timeout: ... validation error.
Expected behavior
Invalid timeout inputs should consistently be converted into ArgumentTypeError, just like zero or negative values already are, so argparse can render a clean user-facing error message.
Proposed fix
Wrap the float(value) conversion in timeout_check() and re-raise invalid inputs as ArgumentTypeError, then add a regression test for invalid timeout values.
Summary
Passing a non-numeric timeout to the CLI currently raises a raw
ValueErrorfromfloat(value)instead of surfacing an argparse validation error.Reproduction
Current behavior
The CLI blows up while parsing arguments instead of reporting a normal
argument --timeout: ...validation error.Expected behavior
Invalid timeout inputs should consistently be converted into
ArgumentTypeError, just like zero or negative values already are, so argparse can render a clean user-facing error message.Proposed fix
Wrap the
float(value)conversion intimeout_check()and re-raise invalid inputs asArgumentTypeError, then add a regression test for invalid timeout values.