Merge pull request #392 from asottile/cache-dir-with-extendedregexp

fix pre_commit_cache_dir when grep.extendedRegexp=true

Author: asottile

all_repos/autofix/pre_commit_cache_dir.py

@@ -8,16 +8,26 @@
 from all_repos.config import Config
 from all_repos.grep import repos_matching
 
-
-APPVEYOR = 'appveyor.yml'
-TRAVIS = '.travis.yml'
+REPLACES = (
+    (
+        'appveyor.yml',
+        r'%USERPROFILE%\.pre-commit',
+        r'%USERPROFILE%\.cache\pre-commit',
+    ),
+    (
+        '.travis.yml',
+        '$HOME/.pre-commit',
+        '$HOME/.cache/pre-commit',
+    ),
+)
 
 
 def find_repos(config: Config) -> set[str]:
-    return (
-        repos_matching(config, ('$HOME/.pre-commit', '--', TRAVIS)) |
-        repos_matching(config, (r'%USERPROFILE%\\.pre-commit', '--', APPVEYOR))
-    )
+    return {
+        repo
+        for fname, pattern, _ in REPLACES
+        for repo in repos_matching(config, ('-F', pattern, '--', fname))
+    }
 
 
 def _replace_if_exists(filename: str, s1: str, s2: str) -> None:
@@ -30,11 +40,8 @@ def _replace_if_exists(filename: str, s1: str, s2: str) -> None:
 
 
 def apply_fix() -> None:
-    _replace_if_exists(TRAVIS, '$HOME/.pre-commit', '$HOME/.cache/pre-commit')
-    _replace_if_exists(
-        APPVEYOR,
-        r'%USERPROFILE%\.pre-commit', r'%USERPROFILE%\.cache\pre-commit',
-    )
+    for fname, find, replace in REPLACES:
+        _replace_if_exists(fname, find, replace)
 
 
 def main(argv: Sequence[str] | None = None) -> int:

tests/autofix/pre_commit_cache_dir_test.py

@@ -1,5 +1,8 @@
 from __future__ import annotations
 
+import os
+from unittest import mock
+
 from all_repos import clone
 from all_repos.autofix.pre_commit_cache_dir import main
 from testing.git import write_file_commit
@@ -66,3 +69,13 @@ def test_main(file_config_files):
         r"  - '%LOCALAPPDATA%\pip\cache'\n"
         r"  - '%USERPROFILE%\.cache\pre-commit'\n"
     )
+
+
+def test_with_extended_regexp(file_config_files):
+    git_env = {
+        'GIT_CONFIG_COUNT': '1',
+        'GIT_CONFIG_KEY_0': 'grep.extendedRegexp',
+        'GIT_CONFIG_VALUE_0': 'true',
+    }
+    with mock.patch.dict(os.environ, git_env):
+        test_main(file_config_files)